Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for cairo::Context::set_dash and get_dash #190

Merged
merged 3 commits into from
Feb 6, 2015
Merged

Fixes for cairo::Context::set_dash and get_dash #190

merged 3 commits into from
Feb 6, 2015

Conversation

SimonSapin
Copy link
Contributor

Please see individual commit messages, and confirm that the test fails on the second commit and is fixed on the third. I was not able to run tests locally.

@SimonSapin
Remove the num_dashes parameter and use the dashes slice length in Co…
7442a07 
…ntext::set_dash
@SimonSapin
Add a sanity test for Context::set_dash and get_dash.
21a2c91 
The test *should* be failing with `([], 42) != ([3, 2, 1], 42)`,
but it segfaults on my machine (even on master)
for reasons I did not bother to investigate.
@SimonSapin
Set a non-zero length for the vector returned by Context::get_dash.
c9f11c0 
This should fix the test added in the previous commit.
@SimonSapin
Copy link
Contributor Author

Uh, it looks like cairotest didn’t fail on Travis at the second commit like I expected. Either this test is not actually run, or I don’t understand what’s going on.

https://travis-ci.org/jeremyletang/rgtk/builds/49418200

@GuillaumeGomez
Copy link
Contributor

Thanks for your contribution ! We're just compiling on travis, not testing.
We test on our computers.
Le 4 févr. 2015 07:20, "Simon Sapin" notifications@github.com a écrit :

Uh, it looks like cairotest didn’t fail on Travis at the second commit
like I expected. Either this test is not actually run, or I don’t
understand what’s going on.

https://travis-ci.org/jeremyletang/rgtk/builds/49418200

—
Reply to this email directly or view it on GitHub
#190 (comment).

@SimonSapin
Copy link
Contributor Author

Oh, I see. Travis runs cd ../cairotest && cargo build, not && cargo run

@GuillaumeGomez
Copy link
Contributor

It would be difficult since it's a graphic software...

2015-02-04 7:36 GMT+01:00 Simon Sapin notifications@github.com:

Oh, I see. Travis runs cd ../cairotest && cargo build, not && cargo run

—
Reply to this email directly or view it on GitHub
#190 (comment).

web CV : www.guillaume-gomez.fr http://www.guillaume-gomez.fr
portable: +33 6 21 92 31 88

@SimonSapin
Copy link
Contributor Author

Yeah, I understand. I just made an incorrect assumption when first looking at the results.

@GuillaumeGomez
Copy link
Contributor

No problem. I'll take a look at your PR this evening.

GuillaumeGomez added a commit that referenced this pull request Feb 6, 2015
@GuillaumeGomez
Merge pull request #190 from SimonSapin/dash
b943618 
Fixes for cairo::Context::set_dash and get_dash
@GuillaumeGomez GuillaumeGomez merged commit b943618 into jeremyletang:master Feb 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonSapin @GuillaumeGomez