Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FP]: Serilog.Sinks.Async #6056

Closed
HarshalSuple opened this issue Nov 14, 2023 · 4 comments
Closed

[FP]: Serilog.Sinks.Async #6056

HarshalSuple opened this issue Nov 14, 2023 · 4 comments

Comments

@HarshalSuple
Copy link

Package URl

pkg:nuget/Serilog.Sinks.Async@1.5.0

CPE

cpe:2.3:a:async_project:async:1.5.0:::::::*

CVE

CVE-2021-43138

ODC Integration

None

ODC Version

8.3.1

Description

Vulnerability in https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md#v264 is reported for package "Serilog.Sinks.Async".
Source : https://github.com/serilog/serilog-sinks-async

image

It should refer the package from the source repository but instead of that it is referring from https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md#v264. Hence showing the "Serilog.Sinks.Async" package as vulnerable.

Copy link
Contributor

Nuget Coordinates

dotnet add package Serilog.Sinks.Async --version 1.5.0

Suppression rule:

<suppress base="true">
   <notes><![CDATA[
   FP per issue #6056
   ]]></notes>
   <packageUrl regex="true">^pkg:nuget/Serilog\.Sinks\.Async@.*$</packageUrl>
   <cpe>cpe:/a:async_project:async</cpe>
</suppress>

Link to test results: https://github.com/jeremylong/DependencyCheck/actions/runs/6860591340

@aikebah
Copy link
Collaborator

aikebah commented Nov 21, 2023

approved

Copy link
Contributor

Suppress rule has been added to the generatedSuppressions branch.

github-actions bot added a commit that referenced this issue Nov 21, 2023
@HarshalSuple
Copy link
Author

HarshalSuple commented Nov 27, 2023

Hello @aikebah, the suppression which got approved did not reduced the false positive dependency check count. So I guess Package Url I gave was somewhat wrong. Appologies for that. Can you please check the below image for the package Url.

MicrosoftTeams-image

The Package Url which I mentioned i.e "pkg:nuget/Serilog.Sinks.Async@1.5.0" is correct or it should be like in the image "pkg:generic/Serilog.Sinks.Async@1.5.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants