Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make Central URL configurable via CLI #5667

Merged
merged 2 commits into from
Apr 19, 2023
Merged

fix: Make Central URL configurable via CLI #5667

merged 2 commits into from
Apr 19, 2023

Conversation

Hacktix
Copy link
Contributor

@Hacktix Hacktix commented Apr 19, 2023

Fixes Issue

n/a, no issue for this feature exists

Description of Change

URL used by Central Analyzer can be defined via --centralUrl. Default value is still taken from properties file.
Also adjusted error message resulting from XML Parsing Errors in Central Analyzer to clarify where the errors come from.

Have test cases been added to cover the new functionality?

no

@boring-cyborg boring-cyborg bot added cli changes to the cli core changes to core documentation site documentation labels Apr 19, 2023
Copy link
Owner

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong added this to the 8.2.2 milestone Apr 19, 2023
@jeremylong jeremylong merged commit 7f7a498 into jeremylong:main Apr 19, 2023
@jeremylong
Copy link
Owner

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli changes to the cli core changes to core documentation site documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants