Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds maven configuration switches for more analyzers #635

Merged
merged 1 commit into from
Jan 8, 2017

Conversation

hgschmie
Copy link
Contributor

No description provided.

@jeremylong
Copy link
Owner

For the non-FileTypeAnanlyzers I do not believe configuration options should be made available to disable them. These have been added to the core engine for the purposes of allowing plugins to disable a specific analyzer and replace it with a new implementation.

However, as you have pointed out several of the FileTypeAnalyzers do not have configuration options. When this gets merged I plan on:

  1. Removing the configuration options for the non-file type analyzers (unless someone can make a compelling argument for allowing these analyzers to be configured).
  2. Validating that the configuration options exist in the CLI, gradle, and Ant plugins.
  3. Updating the documentation

@hgschmie
Copy link
Contributor Author

Ok. I am less (not :-) interested in digging through the cli, gradle and ant code, so I may not do that. Where would I put a pull request for documentation?

@jeremylong
Copy link
Owner

No worries about the other interfaces, I can take care of that. If you don't mind updating the documentation it is in the maven site for each of the interfaces. For Maven see https://github.com/jeremylong/DependencyCheck/tree/master/dependency-check-maven/src/site/markdown

@jeremylong jeremylong merged commit a41158a into jeremylong:master Jan 8, 2017
jeremylong added a commit that referenced this pull request Jan 8, 2017
jeremylong added a commit that referenced this pull request Jan 8, 2017
jeremylong added a commit to dependency-check/dependency-check-gradle that referenced this pull request Jan 14, 2017
jeremylong added a commit that referenced this pull request Jan 14, 2017
@lock lock bot locked and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants