This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
Feature/cmake config package #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPMMaia
force-pushed
the
feature/cmake-config-package
branch
from
0b1fa22
to
a8f7c49
Compare
Setting the version of the project will enable creating a CMake package version file.
Add a new option `KLEIN_INSTALL`. When this option is enabled, then a
CMake config-file package will be created during the install step. By
default, this option is set to ON for standalone projects. Otherwise,
the option is set of OFF.
The header files will be installed into `include/klein`. Therefore,
the include directory of the exported targets should be `include`
(i.e. `$<INSTALL_INTERFACE:include>`). To distinguish this from the
include directories during a build we use the `BUILD_INTERFACE`
generator expression (e.g.
`$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/public>`).
if `KLEIN_INSTALL` is set to ON, then the targets are installed and the
CMake config-file package is created. Other CMake projects can then
search for the package using e.g. `find_package(Klein 2.3.0)`.
`klein-config.cmake` will be executed by other projects when using
`find_package`. Since klein depends on the simde headers, the CMake file
will try to find these headers and add them to klein targets include
directories.
JPMMaia
force-pushed
the
feature/cmake-config-package
branch
from
a8f7c49
to
2be42b0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Sorry this is taking me a moment to review just to familiarize myself with vcpkg and all that. Thanks for submitting the pr! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set CMake project version to 2.3.0 Setting the version of the project will enable creating a CMake package version file.
Add a new option
KLEIN_INSTALL. When this option is enabled, then a CMake config-file package will be created during the install step. By default, this option is set to ON for standalone projects. Otherwise, the option is set of OFF.The header files will be installed into
include/klein. Therefore, the include directory of the exported targets should beinclude(i.e.$<INSTALL_INTERFACE:include>). To distinguish this from the include directories during a build we use theBUILD_INTERFACEgenerator expression (e.g.$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/public>).if
KLEIN_INSTALLis set to ON, then the targets are installed and the CMake config-file package is created. Other CMake projects can then search for the package using e.g.find_package(Klein 2.3.0).klein-config.cmakewill be executed by other projects when usingfind_package. Since klein depends on the simde headers, the CMake file will try to find these headers and add them to klein targets includedirectories.