Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support relative paths for index.html loads #6

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

joshuaboniface
Copy link
Contributor

Allows SUI to work at arbitrary path names rather than relying on fixed root-level paths.

Allows SUI to work at arbitrary path names rather than relying on fixed
root-level paths.
@magikmw
Copy link

magikmw commented May 10, 2020

@joshuaboniface Let me know if I got this right:

  • right now sui can only run on paths like sub.example.com/
  • your change makes it possible to run on paths like sub.example.com/directory/index.html

@joshuaboniface
Copy link
Contributor Author

joshuaboniface commented May 10, 2020

@magikmw Yep, that's right! As a test, I put SUI at myserver.tld/sui/ under a manual web root (no Docker) and these assets were all trying to be loaded out of myserver.tld/. Now they'll load out of whatever directory index.html is in.

@magikmw
Copy link

magikmw commented May 14, 2020

@joshuaboniface Thanks! I've merged the change with my fork.

@jeroenpardon jeroenpardon merged commit 4ca0116 into jeroenpardon:master Jun 5, 2020
@jeroenpardon
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants