(Github Comment Enhancer) Chrome browser compatibility #11

Closed
tophf opened this Issue Aug 29, 2014 · 1 comment

Projects

None yet

2 participants

@tophf
Contributor
tophf commented Aug 29, 2014

Uncaught TypeError: undefined is not a function at this line

document.querySelectorAll returns not an array but a NodeList object which has no (should have no) method forEach.

The workarounds.

@jerone
Owner
jerone commented Aug 29, 2014

This code indeed has issues with Chrome. I build it for Firefox and that browser supports the shortcut Array.forEach. Every other browser you have to use Array.prototype.forEach.

If you add a PR with your fixes, I'm willing to merge it in...

@jerone jerone added the bug label Aug 29, 2014
@jerone jerone closed this in #12 Aug 29, 2014
@jerone jerone changed the title from Github Comment Enhancer - Chrome browser compatibility to (Github Comment Enhancer) Chrome browser compatibility Aug 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment