Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Comment Enhancer - Chrome browser compatibility #12

Merged
merged 1 commit into from
Aug 29, 2014
Merged

Github Comment Enhancer - Chrome browser compatibility #12

merged 1 commit into from
Aug 29, 2014

Conversation

tophf
Copy link
Contributor

@tophf tophf commented Aug 29, 2014

Closes #11

jerone added a commit that referenced this pull request Aug 29, 2014
Chrome browser compatibility with Array.forEach
@jerone jerone merged commit 832706c into jerone:master Aug 29, 2014
@jerone
Copy link
Owner

jerone commented Aug 29, 2014

Thnx! I've merged your commit and everything still works. Will release new version soon.

Do you want me to add yourself as contributor?

// @contributor tophf (https://github.com/tophf)

@jerone jerone added the bug label Aug 29, 2014
@tophf
Copy link
Contributor Author

tophf commented Aug 29, 2014

Not necessary in general I think, but if you publish a short changelog you could mention me there, otherwise my contribution is visible in the commit history anyway.

BTW, you can add to README the Chrome compatibility note, at least the new script works here in Chrome being installed manually by drag'n'dropping into the Extensions tab, dunno about Tampermonkey but should be okay probably (needs testing though).

@jerone
Copy link
Owner

jerone commented Aug 30, 2014

Did some testing today and got it working for TamperMonkey too.
Just released new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Github Comment Enhancer) Chrome browser compatibility
2 participants