Allowing users to customize timestamp format printed by pretty_ts() function #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perceptron01
commented
Aug 23, 2021
| @@ -78,6 +78,7 @@ def load_conf(args, defaults=None, overwrites=None): | |||
| conf.setdefault('disable_rules_on_error', True) | |||
| conf.setdefault('scan_subdirectories', True) | |||
| conf.setdefault('rules_loader', 'file') | |||
| conf.setdefault('custum_pretty_ts_format', None) | |||
There was a problem hiding this comment.
There is a typo in this line
NG: conf.setdefault('custum_pretty_ts_format', None)
OK: conf.setdefault('custom_pretty_ts_format', None)
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds optional configuration of
custom_pretty_ts_format, which provides a way to define custom format of timestamps printed in log messages and in alert messages.This function is realized by modifying pretty_ts() function inutil.pyand its related components.custom_pretty_ts_formatis expected to be specified like this inconfig.yaml.Checklist
make test-dockerwith my changes.Questions or Comments
CHANGELOG.md will be updated after the number of PR is fixed.Updating CHANGELOG.md has been done.