Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alert handler to create Datadog Events #81

Merged
merged 5 commits into from
Apr 23, 2021

Conversation

3vanlock
Copy link
Contributor

@3vanlock 3vanlock commented Apr 23, 2021

Create a new alerter that sends Datadog Events via their API.

@nsano-rururu
Copy link
Collaborator

@3vanlock

I think I need to add a description of the datadog configuration to elastalert/docs/source/ruletypes.rst.
Since the first character is d, I think it is good to add it between command and email.

Example)

Datadog
~~~~~~~

Events are limited to 4000 characters. If an event is sent that contains a message that is longer than 4000 characters, only his first 4000 characters will be displayed.

datadog_api_key: Datadog API key.

datadog_app_key: Datadog Application key.

@3vanlock
Copy link
Contributor Author

add a description of the datadog configuration to elastalert/docs/source/ruletypes.rst

Done @nsano-rururu. Thanks for the structure. I added a couple of links to Datadog's own Event documentation.

@jertel
Copy link
Owner

jertel commented Apr 23, 2021

I see some of the other alerts have unit tests. Should a test, or tests, be added for this new logic?

@3vanlock
Copy link
Contributor Author

Good call @jertel. I added a new test following the style of the old tests and ran it with success locally.

@jertel jertel merged commit 1c6ed32 into jertel:alt Apr 23, 2021
@3vanlock 3vanlock deleted the add-datadog-alerter branch April 23, 2021 20:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants