Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to add tags, tlp, and message in TheHive observables #873

Merged
merged 12 commits into from
Jun 1, 2022

Conversation

luffynextgen
Copy link
Contributor

@luffynextgen luffynextgen commented May 31, 2022

Description

I added the possibility to add tags, modify tlp level and add messages on TheHive observables.
There is no breaking change.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

I do not have a docker environment so I ran the test to develop the feature on my test environment

@luffynextgen
Copy link
Contributor Author

image

That's weird...

Copy link
Owner

@jertel jertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@jertel jertel merged commit cb4af7a into jertel:master Jun 1, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants