Change 'metrics' to 'metrics.enabled' in helm chart documentation #981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to the original documentation of values in README.md, one might think
metrics
are enabled just by defining themetrics
key like this:However,
templates/service.yaml
and other files don't check if themetrics
key exists, but how theenabled
value is set. The same value is defined invalues.yaml
. The documentation has been modified to make it clear that the valuemetrics.enabled
must be explicitly defined.Checklist
make test-docker
with my changes.Questions or Comments