Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: misc styles #691

Merged
merged 4 commits into from
Dec 11, 2023
Merged

Fix: misc styles #691

merged 4 commits into from
Dec 11, 2023

Conversation

hmerritt
Copy link
Contributor

@hmerritt hmerritt commented Dec 6, 2023

Description

  • Fix: react map key error (not tracking looped items with a key causes react to throw an error)
  • Fix: ui spacing
    • Torrent alert wrapper spacing - Text and button were a little too close together
    • Give the "location" item in the Expanded torrent more breathing-room (increase width)

Related Issue

Screenshots

Increased spacing between the text and the button:
image

Increased maximum width for directory/location:
image

Types of changes

  • Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • New feature (non-breaking change which adds functionality - semver MINOR)
  • Bug fix (non-breaking change which fixes an issue - semver PATCH)

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (f93c569) 73.15% compared to head (57b63ef) 73.13%.
Report is 1 commits behind head on master.

Files Patch % Lines
server/routes/index.ts 25.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #691      +/-   ##
==========================================
- Coverage   73.15%   73.13%   -0.03%     
==========================================
  Files          62       62              
  Lines       11384    11375       -9     
  Branches      961      959       -2     
==========================================
- Hits         8328     8319       -9     
  Misses       3042     3042              
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trim21 trim21 enabled auto-merge (squash) December 11, 2023 20:59
@trim21 trim21 merged commit 725fbb4 into jesec:master Dec 11, 2023
12 checks passed
@hmerritt hmerritt deleted the fix/misc-styles branch December 15, 2023 00:47
trim21 pushed a commit to trim21/flood that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants