Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): @fastify/express doesn't work with http2 #705

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Conversation

trim21
Copy link
Collaborator

@trim21 trim21 commented Dec 11, 2023

Description

Related Issue

close #696

Screenshots

Types of changes

  • Breaking change (changes that break backward compatibility of public API or CLI - semver MAJOR)
  • New feature (non-breaking change which adds functionality - semver MINOR)
  • Bug fix (non-breaking change which fixes an issue - semver PATCH)

@trim21 trim21 marked this pull request as ready for review December 11, 2023 18:24
@trim21 trim21 enabled auto-merge (squash) December 11, 2023 18:25
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e523a29) 73.15% compared to head (808a687) 73.15%.

❗ Current head 808a687 differs from pull request most recent head 6c310df. Consider uploading reports for the commit 6c310df to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   73.15%   73.15%           
=======================================
  Files          62       62           
  Lines       11384    11384           
  Branches      961      965    +4     
=======================================
  Hits         8328     8328           
  Misses       3042     3042           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

server/bin/web-server.ts Outdated Show resolved Hide resolved
server/bin/web-server.ts Outdated Show resolved Hide resolved
@trim21 trim21 merged commit 40eac66 into master Dec 11, 2023
10 checks passed
@trim21 trim21 deleted the trim21-patch-1 branch December 11, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on startup with latest Docker (master)
1 participant