Remove deprecated std::unary/binary_function #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elegant996
added a commit
to Elegant996/rtorrent
that referenced
this pull request
Jul 29, 2023
commit 199e8f8 Author: Aleksa Sarai <cyphar@cyphar.com> Date: Mon Jun 20 19:09:57 2022 +1000 utils: lockfile: avoid stack overflow for lockfile buffer There appears to have been some change on openSUSE (likely some new hardening flags for builds, or some glibc hardening) such that incorrect buffer handling results in a segfault even if the buffer is never overflowed. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com> commit e9303f6 Author: kannibalox <kannibalox@gmail.com> Date: Tue Jul 4 02:56:29 2023 -0400 Remove deprecated std::unary/binary_function (jesec#46) commit 7a3fc21 Author: kannibalox <kannibalox@gmail.com> Date: Tue Jul 4 02:55:42 2023 -0400 option_parser: fix unqualified calls to std::move (jesec#59) https://reviews.llvm.org/rG70b1f6de539867353940d3dcb8b25786d5082d63 commit f9a875b Author: Jesse Chan <jc@linux.com> Date: Mon Jul 3 16:13:23 2023 -0700 download_store: ensure that session files land on the disk Currently, save() stores session to the disk by: - serialize to bencode and write to files with .new ext - validate the new files - rename new files, removing .new ext Technically, this is done to make sure that session files on the disk are always valid/uncorrupted. However, if catastrophic events happen during save(), such as system crash / power outage, the actual content of session files may not have been synced to the disk. To make things much worse, rename() is atomic. That means we discarded the previous session files without actually landing the new session files on the disk, and we got a bunch of empty session files to deal with. This commit adds a fsync step to ensure that session files land on the disk.
Elegant996
added a commit
to Elegant996/rtorrent
that referenced
this pull request
Jul 31, 2023
commit 199e8f8 Author: Aleksa Sarai <cyphar@cyphar.com> Date: Mon Jun 20 19:09:57 2022 +1000 utils: lockfile: avoid stack overflow for lockfile buffer There appears to have been some change on openSUSE (likely some new hardening flags for builds, or some glibc hardening) such that incorrect buffer handling results in a segfault even if the buffer is never overflowed. Signed-off-by: Aleksa Sarai <cyphar@cyphar.com> commit e9303f6 Author: kannibalox <kannibalox@gmail.com> Date: Tue Jul 4 02:56:29 2023 -0400 Remove deprecated std::unary/binary_function (jesec#46) commit 7a3fc21 Author: kannibalox <kannibalox@gmail.com> Date: Tue Jul 4 02:55:42 2023 -0400 option_parser: fix unqualified calls to std::move (jesec#59) https://reviews.llvm.org/rG70b1f6de539867353940d3dcb8b25786d5082d63 commit f9a875b Author: Jesse Chan <jc@linux.com> Date: Mon Jul 3 16:13:23 2023 -0700 download_store: ensure that session files land on the disk Currently, save() stores session to the disk by: - serialize to bencode and write to files with .new ext - validate the new files - rename new files, removing .new ext Technically, this is done to make sure that session files on the disk are always valid/uncorrupted. However, if catastrophic events happen during save(), such as system crash / power outage, the actual content of session files may not have been synced to the disk. To make things much worse, rename() is atomic. That means we discarded the previous session files without actually landing the new session files on the disk, and we got a bunch of empty session files to deal with. This commit adds a fsync step to ensure that session files land on the disk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While building this on Arch, I received the following error:
From research, nothing inside rtorrent should require this base class, so I simply removed it. There's an associated PR for libtorrent here: jesec/libtorrent#8