Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment targets inconsistency between Pod and SPM metafiles #18

Closed
kambala-decapitator opened this issue Jun 5, 2021 · 1 comment · Fixed by #19
Closed

Deployment targets inconsistency between Pod and SPM metafiles #18

kambala-decapitator opened this issue Jun 5, 2021 · 1 comment · Fixed by #19
Labels
Milestone

Comments

@kambala-decapitator
Copy link

Have you read the Contributing Guidelines?
yes

General Information

  • Project version:

1.1.0 / the latest state

  • Platform/OS version:

doesn't matter

  • IDE version:

doesn't matter

  • Devices:

doesn't matter

  • Any related GitHub issues:

Describe the bug

Clearly and concisely describe the bug.
Podspec declares deployment targets as 12.0 / 10.13 while Package.swift says 13 / 10.15.

Steps to reproduce

Provide numbered steps to follow that reproduce the bug.
No steps.

Expected behavior

Clearly and concisely describe what you expected to happen.
Deployment targets are identical.

Stack trace, compiler error, code snippets

Paste the full output of any stack trace or compiler error.
Include a code snippet that reproduces the described behavior, if applicable
https://github.com/jessesquires/Foil/blob/main/Foil.podspec#L17
https://github.com/jessesquires/Foil/blob/main/Package.swift#L23

Screenshots

If applicable, add screenshots, gifs, or videos to help explain your problem.

Additional context

Add any other useful information about the problem here.

  • SPM doesn't support tvOS and watchOS (dunno if that's possible at all though)
  • also make sure that deployment targets in Xcode projects are synced
@jessesquires jessesquires added this to the NEXT milestone Jun 5, 2021
@jessesquires
Copy link
Owner

Ah, great catch. 💯

Thank you @kambala-decapitator ! 🙌🏼

jessesquires added a commit that referenced this issue Jun 5, 2021
- Lower iOS and tvOS to 9.0, closes #16
- Correct SPM platforms and make consistent with podspec, closes #18

This also separates tests into `ObservationTests`, which we can mark as `@available` so that building/running via SPM works.
jessesquires added a commit that referenced this issue Jun 6, 2021
- Lower iOS and tvOS to 9.0, closes #16
- Correct SPM platforms and make consistent with podspec, closes #18

This also separates tests into `ObservationTests`, which we can mark as `@available` so that building/running via SPM works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants