Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(no-done-callback): support hooks #656

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Sep 4, 2020

Fixes #649
Resolves #651

@G-Rath G-Rath requested a review from SimenB September 4, 2020 05:47
@SimenB SimenB changed the title no-done-callback/support-hooks feat(no-done-callback): support hooks Sep 4, 2020
@SimenB SimenB merged commit 0474d3c into next Sep 4, 2020
@SimenB SimenB deleted the no-done-callback/support-hooks branch September 4, 2020 10:56
SimenB pushed a commit that referenced this pull request Sep 4, 2020
BREAKING CHANGE: `no-done-callback` will now report hooks using callbacks as well, not just tests

Fixes #649
Resolves #651
SimenB pushed a commit that referenced this pull request Sep 4, 2020
BREAKING CHANGE: `no-done-callback` will now report hooks using callbacks as well, not just tests

Fixes #649
Resolves #651
SimenB pushed a commit that referenced this pull request Sep 4, 2020
BREAKING CHANGE: `no-done-callback` will now report hooks using callbacks as well, not just tests

Fixes #649
Resolves #651
github-actions bot pushed a commit that referenced this pull request Sep 4, 2020
# [24.0.0](v23.20.0...v24.0.0) (2020-09-04)

### Bug Fixes

* **no-large-snapshots:** run on all files regardless of type ([#637](#637)) ([22113db](22113db)), closes [#370](#370)
* remove Jasmine globals ([#596](#596)) ([a0e2bc5](a0e2bc5))
* update to typescript-eslint@4 ([1755965](1755965)), closes [#590](#590)

### Code Refactoring

* **no-test-callback:** rename rule to `no-done-callback` ([#653](#653)) ([e15a8d1](e15a8d1))

### Features

* **no-done-callback:** support hooks ([#656](#656)) ([3e6cb44](3e6cb44)), closes [#649](#649) [#651](#651)
* add `no-conditional-expect` to the recommended ruleset ([40cd89d](40cd89d))
* add `no-deprecated-functions` to the recommended ruleset ([5b2af00](5b2af00))
* add `no-interpolation-in-snapshots` to the recommended ruleset ([3705dff](3705dff))
* add `valid-title` to recommended ruleset ([41f7873](41f7873))
* drop support for node 8 ([#570](#570)) ([6788e72](6788e72))
* set `no-jasmine-globals` to `error` in recommended ruleset ([7080952](7080952))
* **no-large-snapshots:** remove `whitelistedSnapshots` option ([8c1c0c9](8c1c0c9))

### BREAKING CHANGES

* **no-done-callback:** `no-done-callback` will now report hooks using callbacks as well, not just tests
* **no-test-callback:** rename `no-test-callback` to `no-done-callback`
* recommend `no-conditional-expect` rule
* recommend `no-interpolation-in-snapshots` rule
* recommend `no-deprecated-functions` rule
* recommend `valid-title` rule
* recommend erroring for `no-jasmine-globals` rule
* **no-large-snapshots:** `no-large-snapshots` runs on all files regardless of type
* Jasmine globals are no marked as such
* Node 10+ required
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants