Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade dependency to the latest #97

Merged
merged 3 commits into from
Dec 25, 2022

Conversation

connectdotz
Copy link
Collaborator

@connectdotz connectdotz commented Dec 21, 2022

Upgrade all dependencies to the latest and fix eslint/flow related errors.

There are quite a few type erasure issues when importing typescript types in flow files that the latest flow starts to complain about. I end up adding the $FlowIgnore to bypass these warnings. I think we should put a consistent effort into migrating to typescript sooner than later...

fixes #96

@connectdotz connectdotz merged commit f9b0a91 into jest-community:master Dec 25, 2022
@connectdotz connectdotz deleted the upgrade-dep branch December 25, 2022 18:00
@adrienbaron
Copy link

@connectdotz Happy New Year 🥳!

Thank you for this PR!
I'm having the same issue this fixes using the VSCode Jest extension in my repo, and looking into fixing it I realised the issue wasn't there when running the extension locally and discovered you've fixed it already 🙇‍♂️!

Is there anything I can do to help getting this and a new version of the extension using it released?

@connectdotz
Copy link
Collaborator Author

@adrienbaron, Happy new year!

Sorry, still in holiday coma, should be back next week.

I was working on one more PR and plan to release a new version of this library, then vscode-jest afterward. Thanks for the offering; I will keep that in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser crashes on TypeScript inline type imports
2 participants