Allow <rootDir> placeholder to be used in the output option. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
approved these changes
Sep 29, 2018
SimenB
approved these changes
Sep 29, 2018
|
Is there anything else that I should do at this point, or do I just wait for the merge to happen? Thanks. |
|
@palmerj3 should take a look whenever he finds the time and do the merge and release 🙂 |
|
Looks great! |
|
Thanks all, appreciate it. |
|
Just published v5.2.0 |
Awesome. Just downloaded latest package and all works fine in my project. Thanks guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49
Changes to allow
<rootDir>placeholder to be used in theoutputoption. Useful whenjest-junitis used in a monorepo environment, where you want each project to have its own test result. In a monorepo jestrootDirwill be the path of whatever the project under test is.Had to add
jest-configas a dependency in order to access the same function that jest uses to replace the<rootDir>placeholder. Thought this would be a better option than writing a custom replacer, as it keeps it consistent with jest.Thanks