address feedback

Author: thymikee

__tests__/__snapshots__/snapshotDiff.test.js.snap

@@ -144,3 +144,23 @@ exports[`supports diffing single-line strings 1`] = `
 + bar
   "
 `;
+
+exports[`supports diffing single-line strings 2`] = `
+"Snapshot Diff:
+- First value
++ Second value
+
+- foo
++ bar
+  "
+`;
+
+exports[`supports diffing single-line strings 3`] = `
+"Snapshot Diff:
+- First value
++ Second value
+
+- foo
++ bar
+  "
+`;

__tests__/snapshotDiff.test.js

@@ -58,6 +58,8 @@ class Component extends React.Component<Props> {
 
 test('supports diffing single-line strings', () => {
   expect(snapshotDiff('foo', 'bar')).toMatchSnapshot();
+  expect(snapshotDiff('foo\n', 'bar')).toMatchSnapshot();
+  expect(snapshotDiff('foo', 'bar\n')).toMatchSnapshot();
 });
 
 test('collapses diffs and strips ansi by default', () => {

src/index.js

@@ -51,12 +51,11 @@ const isReactComponent = (value: any) =>
   value && value.$$typeof === reactElement;
 
 function diffStrings(valueA: any, valueB: any, options: Options) {
-  const multiline =
-    MULTILINE_REGEXP.test(valueA) && MULTILINE_REGEXP.test(valueB);
-
   // jest-diff doesn't support single-line values, but we want to
-  if (typeof valueA === 'string' && typeof valueB === 'string' && !multiline) {
+  if (typeof valueA === 'string' && !MULTILINE_REGEXP.test(valueA)) {
     valueA += '\n'; // eslint-disable-line no-param-reassign
+  }
+  if (typeof valueB === 'string' && !MULTILINE_REGEXP.test(valueB)) {
     valueB += '\n'; // eslint-disable-line no-param-reassign
   }