Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify setupFiles run order #11641

Merged
merged 1 commit into from
Nov 29, 2021
Merged

docs: Clarify setupFiles run order #11641

merged 1 commit into from
Nov 29, 2021

Conversation

tamlyn
Copy link
Contributor

@tamlyn tamlyn commented Jul 5, 2021

Summary

Just a small text change. Previously it was a bit misleading to say that setupFiles is executed "immediately" before executing the test code itself and then go on to say that setupFilesAfterEnv is executed in between those two events.

Sorry about the two commits – just doing this quickly in the web UI. Let me know if I should squash them.

Test plan

n/a

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left a small q.

And could you update the other versioned docs as well?
image

docs/Configuration.md Show resolved Hide resolved
@SimenB
Copy link
Member

SimenB commented Sep 29, 2021

@tamlyn ping 🙂

@tamlyn
Copy link
Contributor Author

tamlyn commented Sep 29, 2021

Updated docs for other versions and squashed commits.

@SimenB
Copy link
Member

SimenB commented Sep 29, 2021

Sorry, should have taken a full screenshot 😅

image

27.1 and 27.2 still needs an update 🙂

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2021

Codecov Report

Merging #11641 (472b0a5) into main (8f406f3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #11641   +/-   ##
=======================================
  Coverage   68.74%   68.74%           
=======================================
  Files         322      322           
  Lines       16591    16591           
  Branches     4787     4787           
=======================================
  Hits        11405    11405           
  Misses       5153     5153           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f406f3...472b0a5. Read the comment docs.

@tamlyn
Copy link
Contributor Author

tamlyn commented Sep 29, 2021

Oh sorry, I hadn't updated my remote! Rebased and amended.

@tamlyn
Copy link
Contributor Author

tamlyn commented Nov 23, 2021

Bump. Anything I need to do for this?

@SimenB SimenB merged commit c739748 into jestjs:main Nov 29, 2021
@SimenB
Copy link
Member

SimenB commented Nov 29, 2021

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants