-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Clarify setupFiles run order #11641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tamlyn ping 🙂 |
Updated docs for other versions and squashed commits. |
Codecov Report
@@ Coverage Diff @@
## main #11641 +/- ##
=======================================
Coverage 68.74% 68.74%
=======================================
Files 322 322
Lines 16591 16591
Branches 4787 4787
=======================================
Hits 11405 11405
Misses 5153 5153
Partials 33 33 Continue to review full report at Codecov.
|
Oh sorry, I hadn't updated my remote! Rebased and amended. |
Bump. Anything I need to do for this? |
Thanks! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Just a small text change. Previously it was a bit misleading to say that
setupFiles
is executed "immediately" before executing the test code itself and then go on to say thatsetupFilesAfterEnv
is executed in between those two events.Sorry about the two commits – just doing this quickly in the web UI. Let me know if I should squash them.
Test plan
n/a