-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(environment-jsdom): allow passing html content to jsdom environment #11950
Conversation
Hi @MarvelSQ! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! This needs tests, a changelog entry, and an update to the docs
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
1 similar comment
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
cddb900
to
6103b55
Compare
Codecov Report
@@ Coverage Diff @@
## main #11950 +/- ##
==========================================
- Coverage 68.76% 68.76% -0.01%
==========================================
Files 322 322
Lines 16620 16623 +3
Branches 4795 4798 +3
==========================================
+ Hits 11429 11430 +1
- Misses 5159 5160 +1
- Partials 32 33 +1
Continue to review full report at Codecov.
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! just some formatting nits 🙂
formatting error fixed |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Allow developer to modify html content through
testEnvironmenrOptions.html
Test plan
cause of some module rely on document elements
current behavior
by passing a html to jsdom, i can avoid this error