-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update docusaurus #12500
chore: update docusaurus #12500
Conversation
This fails since we haven't done https://docusaurus.io/blog/2021/11/21/algolia-docsearch-migration. @slorber how do we solve this? 😅 I've never gotten an email from Algolia (I'm probably not a "site owner" tho) |
@shortcuts can tell who's the site owner and eventually set a new one. I guess it's better if Meta owns the Algolia account for Jest? 🤷♂️ |
Hey, checking.. Edit: on my side @vjeux is the owner of the Jest account, but the invite expired (7 days validity). Let me know if I should add anyone else, you'll then be able to manage team members yourself |
Thanks! Makes sense for some Meta employee (or them as an org) being admin, yes 🙂 |
@SimenB this is related to a breaking change we did on the TOC component: now the TOC structure is "flat" instead of being a tree: facebook/docusaurus#6729 When running locally on those reported URLs you can see a better console error. Some of the Jest pages are using inline TOCs with some TOC filtering and should be updated accordingly. It's not possible anymore to access - <TOCInline toc={toc[toc.length - 1].children}/>
+ <TOCInline toc={toc.slice(2)} /> cc @Josh-Cena maybe we should have a clearer error message? I don't think this would impact a lot of users though 🤷♂️ |
There isn't much we can do, since the const toc = [
{
get children() { throw new Error("children doesn't exist"); }
},
]; which is just weird... |
was more thinking about throwing if toc is undefined, but probably useless Let's see if someone else come up with a similar problem |
Aha, thanks @slorber! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Closes #12432
Test plan
Click around deployment preview