chore: move @jest/test-utils reference
#13468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrazauskas
commented
Oct 18, 2022
| declare const describe: Global.TestFrameworkGlobals['describe']; | ||
| declare const test: Global.TestFrameworkGlobals['test']; | ||
| import semver = require('semver'); | ||
| import {describe, test} from '@jest/globals'; |
There was a problem hiding this comment.
This should work now as expected. Looks right to import from @jest/globals.
mrazauskas
commented
Oct 18, 2022
| @@ -30,7 +30,6 @@ | |||
| "walker": "^1.0.8" | |||
| }, | |||
| "devDependencies": { | |||
| "@jest/test-utils": "workspace:^", | |||
SimenB
reviewed
Oct 18, 2022
|
Any news on this one? 😀 |
|
Thanks for reminder. Got swamped with some stuff, but I will come back very soon. |
|
👋 |
mrazauskas
commented
Feb 4, 2023
SimenB
approved these changes
Feb 4, 2023
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
|
Great stuff, thanks! |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently
@jest/test-utilspackage is referenced inpackages/*/tsconfig.jsonfiles. These tsconfigs exclude./**/__tests__/**/*(all test files), but@jest/test-utilsis used only in the test files.Seems that moving the reference to
__tests__/tsconfig.jsonfiles is more precise.tscwould build types@jest/test-utilsas one of the last and will not think that type other packages depend on@jest/test-utils. Only tests depend on it, but they are excluded from the build tsconfigs.Test plan
Green CI.