Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skipped and todo tests in Github Actions Reporter #14309

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Fix skipped and todo tests in Github Actions Reporter #14309

merged 2 commits into from
Jul 24, 2023
+236 −36

Conversation

MatteoH2O1999
Copy link
Contributor

Summary

Fixes #14278

Test plan

Added relevant unit tests

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 7, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify
Copy link

netlify bot commented Jul 7, 2023 •
edited
Loading

✅ Deploy Preview for jestjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9497eff
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/64bd479afc86500008764bdf
😎 Deploy Preview https://deploy-preview-14309--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MatteoH2O1999 MatteoH2O1999 force-pushed the fix-gha branch 2 times, most recently from 141764a to c3afed2 Compare July 7, 2023 15:57
mrazauskas
mrazauskas approved these changes Jul 8, 2023
View reviewed changes
Copy link
Contributor

@mrazauskas mrazauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! All looks good to my eye.

SimenB
SimenB approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you resolve the conflict? 🙂

packages/jest-reporters/src/__tests__/GitHubActionsReporter.test.ts Outdated
Test,
TestCaseResult,
TestResult,
} from '@jest/test-result';
import type {Config} from '@jest/types';
import GitHubActionsReporter from '../GitHubActionsReporter';
import {normalizeIcons} from '../../../../e2e/Utils';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this helper to @jest/test-utils?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably do that in another PR though

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to this now. @jest/test-utils is an internal package.

@MatteoH2O1999
Copy link
Contributor Author

Conflict solved

mrazauskas
mrazauskas suggested changes Jul 23, 2023
View reviewed changes
Copy link
Contributor

@mrazauskas mrazauskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Very good idea to defined it as a function.

e2e/Utils.ts Outdated
Comment on lines 361 to 362

export {normalizeIcons} from '@jest/test-utils';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reexport is unnecessary. This util is part of the internal testing infrastructure, it isn’t a public API.

Suggested change
export {normalizeIcons} from '@jest/test-utils';

SimenB
SimenB approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 8dd30d0 into jestjs:main Jul 24, 2023
89 checks passed
@MatteoH2O1999 MatteoH2O1999 deleted the fix-gha branch July 24, 2023 13:27
@SimenB
Copy link
Member

SimenB commented Jul 27, 2023

https://github.com/jestjs/jest/releases/tag/v29.6.2

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

@mrazauskas mrazauskas mrazauskas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Github reporter shows skipped tests as failures
3 participants
@MatteoH2O1999 @SimenB @mrazauskas