fix: Revert breaking changes for detectOpenHandles
#14789
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
liuxingbaoyu
changed the title
detectOpenHandlesdetectOpenHandles
liuxingbaoyu
force-pushed
the
revert-detect
branch
from
82e0540
to
280f5d0
Compare
CHANGELOG.md
Outdated
| @@ -10,6 +10,7 @@ | |||
| - `[@jest/core]` [**BREAKING**] Group together open handles with the same stack trace ([#13417](https://github.com/jestjs/jest/pull/13417), & [#14543](https://github.com/jestjs/jest/pull/14543)) | |||
| - `[@jest/core]` Add `perfStats` to surface test setup overhead ([#14622](https://github.com/jestjs/jest/pull/14622)) | |||
| - `[@jest/core]` [**BREAKING**] Changed `--filter` to accept an object with shape `{ filtered: Array<string> }` to match [documentation](https://jestjs.io/docs/cli#--filterfile) ([#13319](https://github.com/jestjs/jest/pull/13319)) | |||
| - `[@jest/core]` [**BREAKING**] Revert breaking changes for `detectOpenHandles`. ([#14789](https://github.com/jestjs/jest/pull/14789)) | |||
There was a problem hiding this comment.
should this entry be grouped with the line on line 10?
There was a problem hiding this comment.
Yes, this looks good to me.
Also the original second PR on line 10 seemed to be irrelevant, so I replaced it.
There was a problem hiding this comment.
We might also be able to remove [**BREAKING**].
|
seems a test is timing out on CI now |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes: #14788
Test plan
CI Green