-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update @babel/code-frame
#14976
Update @babel/code-frame
#14976
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
e2e/runJest.ts
Outdated
NO_COLOR: '1', | ||
FORCE_COLOR: '0', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, while opening this PR I caught a potential regression in Babel. There is no agreed-upon meaning on what FORCE_COLOR
does: according to some it should always force color (https://force-color.org/), because NO_COLOR
always unconditionally disables color and they are opposites. According to others, FORCE_COLOR=0
should disable colors.
Apparently Babel switched from one to the other, so I added this NO_COLOR=1
just to make sure that e2e tests aren't full of colors until when we decide what to do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
There are some changes in how Babel emits ANSI colors. The rendered output is the same, but the sequences differ.