-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Replace chalk
with picocolors
#15197
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
chalk
with picocolors
Probably
|
That makes sense, thanks for pointing it out! :) |
…k-with-picocolors
this might be a bit late, but maybe it helps? es-tooling/module-replacements-codemods#77 |
Much helpful, thanks for sharing @SimenB! Planning to wrap the changes up ASAP, right now stuck on |
@ishon19 This looks like a I mean, if code is compiled using |
Thanks @mrazauskas, yes I agree, I can create an issue on their repo for clarification. |
Hi everyone, I'm really interested with this PR! @ishon19, have you had any time recently to get things moving? 🙏🏻 |
@Kocal If I get it right, this PR is still block because of alexeyraspopov/picocolors#77 |
Thanks @mrazauskas! |
Thanks @Kocal, I know it's waiting for too long and I don't know when the issue this is waiting on is going to be resolved, so if you have any workaround or a better idea to make this happen, please feel free to link a new PR. :) |
Hey @ishon19, don't worry, I wasn't trying to blame you or something like that, I'm just super hyped by your PR because I also want to replace chalk by picocolors (see symfony/webpack-encore#1333 & nuxt/friendly-errors-webpack-plugin#21). I would be really happy to help here, I will take a look today, thanks :) |
Yeah, absolutely! Since you worked on similar issues, really appreciate your feedback :) |
alexeyraspopov/picocolors#82 has been merged |
@Kocal Thanks for the update and the fix as well! |
…k-with-picocolors
@Kocal this change is now available in |
@alexeyraspopov thanks! :) |
Hey @Kocal! Since we have the official confirmation now, I believe we're all set for the upgrade! Unfortunately at this moment, I've got a lot on my plate and I don't want to delay this upgrade any further, please feel free to take this forward if you'd like to. You can open a new PR altogether, or use this one. Let me know if I can help in any way. Appreciate your help :) |
Summary
This PR is for replacing the
chalk
package in the codebase with lighter and fasterpicocolors
owing to the small bundle size (~5Kb
) ofpicocolors
as compared to the existingchalk (~48Kb)
.Test plan
🚧 WIP
Fixes #15189