Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed code coverage on Windows #499

Closed
wants to merge 4 commits into from

Commits on Sep 11, 2015

  1. Fixing code coverage in Windows

    Transform module paths/RegExps so the path matching logic works on Windows.
    Use path.delimiter instead of ":" as a separator in module IDs, since ":" is a valid path character on Windows... All module paths in Windows were getting mapped as {drive letter} which wasn't super-useful.
    Changed a check for absolute paths (check that first character is "/") to a more reliable cross-platform check for absolute paths (use path.isAbsolute).
    Updated tests to expect different paths on different platforms.
    Updated a unit test in HasteModuleLoader-requireMock-test.js to look for a Windows error string as well as the Unix string
    Ryan Oriecuia committed Sep 11, 2015
    Configuration menu
    Copy the full SHA
    e840a7a View commit details
    Browse the repository at this point in the history
  2. Removed Windows-style path checks from unit tests

    We're using Node path utilities now, which will handle posix-to-Windows transformations on Windows, but not Windows-to-posix transfomations on Unix. Removed the unit tests that were making sure we were handling Windows-style paths.
    Ryan Oriecuia committed Sep 11, 2015
    Configuration menu
    Copy the full SHA
    65c25ff View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'upstream/master'

    Ryan Oriecuia committed Sep 11, 2015
    Configuration menu
    Copy the full SHA
    d50c937 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2015

  1. Merge remote-tracking branch 'upstream/master'

    Conflicts:
    	src/TestRunner.js
    Ryan Oriecuia committed Oct 16, 2015
    Configuration menu
    Copy the full SHA
    6e218f4 View commit details
    Browse the repository at this point in the history