fix(jest-runtime): only write map files to disk when mapCoverage: true
#5117
Conversation
SimenB
force-pushed
the
coverage-sourcemaps
branch
from
159e3b2
to
e6769dc
Compare
|
I'm not sure how to properly fix this yet, but I think we should unblock typescript users. I doubt anyone will have had the time to use the new code anyways |
| runJest(dir, ['--coverage', '--mapCoverage', '--no-cache']); | ||
| const result = runJest(dir, ['--coverage', '--mapCoverage', '--no-cache']); | ||
|
|
||
| expect(result.status).toBe(0); |
There was a problem hiding this comment.
this failed on the old code, so I don't think this worked properly anyways
Codecov Report
@@ Coverage Diff @@
## master #5117 +/- ##
=========================================
- Coverage 60.71% 60.7% -0.01%
=========================================
Files 201 201
Lines 6690 6691 +1
Branches 4 4
=========================================
Hits 4062 4062
Misses 2628 2628
- Partials 0 1 +1
Continue to review full report at Codecov.
|
|
Can you file a task to fix the skipped test? |
|
Done: #5121 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
See #5109. This partially reverts #3458 to unblock.
A quick patch release might be a good idea
Test plan
The added assertion (on status
0) fails for the old code, as the integration test actually failed in the same way...