Use precompiled version of jasmine-only #579
Conversation
| var jasmineFileContent = | ||
| fs.readFileSync(require.resolve(JASMINE_PATH), 'utf8'); | ||
| const JASMINE_PATH = require.resolve('../../vendor/jasmine/jasmine-1.3.0'); | ||
| const jasmineFileContent = fs.readFileSync(JASMINE_PATH, 'utf8'); |
There was a problem hiding this comment.
Yeah we only need to require.resolve once.
cpojer
force-pushed
the
master
branch
2 times, most recently
from
24a6537
to
8efc492
Compare
Ship a static, precompiled version of jasmine-only to drop the coffee-script requirement. - Add the precompiled version if jasmine-only to `vendor/jasmine-only/` - Update `src/jasmineTestRunner/jasmineTestRunner.js` to always use the shipped version - Drop coffee-script from `package.json`
|
@facebook-github-bot import |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/108676296160596/int_phab to review. |
|
@facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/108676296160596/int_phab to review. |
ghost
closed this
in
|
I cannot do that @cpojer, because @clentfort does not have an active CLA on file. |
1 similar comment
|
I cannot do that @cpojer, because @clentfort does not have an active CLA on file. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Ship a static, precompiled version of jasmine-only by @davemo to drop the coffee-script requirement. Fixes #578.
Not sure if we need to update the headers of the precompiled file to include the license. FWIW According to the package.json its under the Apache License 2.0.
Test plan:
describe-block and two tests: One created withitand one withit.only, let both tests print to STDOUT, verify only the contents of the test created withit.onlyare printed to STDOUT.describe- and onedescribe.only-block, in both blocks print to STDOUT, verify that only thedescribe.only-block prints to STDOUT.