Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-jasmine2]: Remove throwing an error when return value is not a promise or undefined #6517

Closed
wants to merge 2 commits into from

Conversation

mattphillips
Copy link
Contributor

Summary

Fixes: #6516

Test plan

Tests should all still pass

@mattphillips mattphillips changed the title [jest-jasmine]: Remove throwing an error when return value is not a promise or undefined [jest-jasmine2]: Remove throwing an error when return value is not a promise or undefined Jun 21, 2018
@SimenB SimenB requested a review from aaronabramov June 22, 2018 06:13
@thymikee thymikee requested a review from cpojer July 7, 2018 17:36
@cpojer
Copy link
Member

cpojer commented Jul 7, 2018

We can merge it once an eslint rule exists for this.

@mattphillips
Copy link
Contributor Author

@thymikee
Copy link
Collaborator

thymikee commented Aug 9, 2018

Can you enable it inside jest tests?

@SimenB
Copy link
Member

SimenB commented Dec 25, 2018

What about returning a symbol?

@SimenB
Copy link
Member

SimenB commented Jan 15, 2019

@mattphillips ping 🙂

@SimenB
Copy link
Member

SimenB commented May 3, 2020

This has stalled

@SimenB SimenB closed this May 3, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jest-jasmine2]: Test throws error when a non promise/undefined value is returned
5 participants