Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for recent broader-options watch plugins PR #6696

Merged

Conversation

tdd
Copy link
Contributor

@tdd tdd commented Jul 15, 2018

Summary

A test inside #6473 was unfortunately incorrect and "passed by mistake". This was due to the TTS or an it.each call not using interpolation on dynamic scenario variables, mostly. This fixes it.

Additionally, in the meantime an extra call to updateGlobalConfig had been added to each watch test run, making the original test obsolete in its mock calls inspection. Updated.

Test plan

Well, the tests keep passing, only this time they're correct 😉 so they're actually exercising the scenarios.

Ping @rogeliog @thymikee @SimenB for review.

Refs #6693

@codecov-io
Copy link

Codecov Report

Merging #6696 into master will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6696      +/-   ##
==========================================
+ Coverage    63.6%   63.71%   +0.11%     
==========================================
  Files         235      235              
  Lines        8998     8998              
  Branches        3        3              
==========================================
+ Hits         5723     5733      +10     
+ Misses       3274     3264      -10     
  Partials        1        1
Impacted Files Coverage Δ
packages/jest-cli/src/lib/update_global_config.js 95.45% <0%> (+22.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce52523...f243f6a. Read the comment docs.

@SimenB SimenB merged commit d05e53a into jestjs:master Jul 15, 2018
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants