Fix jest crashing when potentialError is null #7049
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the scenario where a test returns a promise which rejects to null.
Fixes #6896
Closes #6897
Test plan
An end to end test has been added to test for this scenario.
Note that the test assertion has two cases due to jest-jasmine and jest-circus returning different outputs for this case.
Edit:
Acknowledging @Pajn here for the work he has done in #6897.
Just noting that #6897 should also be closed when this PR is accepted.