update jest-haste-map sane dep to sane@4

[nornagon]

Summary

sane <= 3 depends on fsevents, which doesn't compile with node 12. sane 4 removes this dependency.

Test plan

not sure yet 😅

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[nornagon]

(i've signed the cla, but the bot doesn't seem to have updated its message)

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[SimenB]

Duplicate of #7322. I'm not sure how to best handle this. When node 12 comes out, fsevents is gonna drop node 6, and have a napi version. I'm unsure if sane can (or even wants to) add it back.

Also, how does the default watcher work on macos if you haven't installed watchman?

[nornagon]

Ah, hm. Perhaps we could fork sane and publish a patched v3 that had an upgraded fsevents?

[wtgtybhertgeghgtwtg]

Also, how does the default watcher work on macos if you haven't installed watchman?

It uses fs.watch.
I know a new major just came out, but I think it really should be considered. Issues with fs-events and node-pre-gyp have been frequent and are often very involved to resolve upstream. Recently, watchpack dropped fsevents, so the current webpack alpha has been running on fs.watch. rollup also uses fs.watch, though they offer the option to use chokidar. It might be time to bite the bullet.

[SimenB]

#8048

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.