-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jest-each] Fix bug with placeholder values #8289
[jest-each] Fix bug with placeholder values #8289
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8289 +/- ##
==========================================
+ Coverage 62.2% 62.22% +0.01%
==========================================
Files 266 266
Lines 10673 10678 +5
Branches 2595 2596 +1
==========================================
+ Hits 6639 6644 +5
Misses 3445 3445
Partials 589 589
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
@scotthovestadt @SimenB can this be merged? |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Fixes #8286
Basically what is happening is the valid placeholder values are interpolated and then have a knock on effect to the next value to be interpolated into the test title.
This PR stops this from happening by adding an escape to any placeholder values (
%d
) and then removes the all occurrences of the escape at the end of the formattingTest plan
See unit tests.