Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inline snapshot indenting #9523

Merged
merged 5 commits into from
Feb 6, 2020
Merged

Fix inline snapshot indenting #9523

merged 5 commits into from
Feb 6, 2020

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Feb 5, 2020

Summary

Fixes #9477

Test plan

I've added a new test 🌮

@codecov-io
Copy link

Codecov Report

Merging #9523 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9523      +/-   ##
==========================================
+ Coverage   65.02%   65.03%   +0.01%     
==========================================
  Files         283      283              
  Lines       12114    12113       -1     
  Branches     3000     3000              
==========================================
+ Hits         7877     7878       +1     
+ Misses       3598     3597       -1     
+ Partials      639      638       -1
Impacted Files Coverage Δ
packages/jest-snapshot/src/inline_snapshots.ts 82.17% <ø> (+1.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d0d8ba...8a6466b. Read the comment docs.

e2e/__tests__/toMatchInlineSnapshot.test.ts Show resolved Hide resolved
@@ -282,8 +282,6 @@ const createFormattingParser = (
return;
}

snapshotMatcherNames.shift();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, no mutation 😀

@drew-gross

This comment has been minimized.

@codecov-io
Copy link

Codecov Report

Merging #9523 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9523   +/-   ##
=======================================
  Coverage   65.03%   65.03%           
=======================================
  Files         283      283           
  Lines       12113    12113           
  Branches     3000     3000           
=======================================
  Hits         7878     7878           
  Misses       3597     3597           
  Partials      638      638

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 372ced3...cecda64. Read the comment docs.

@SimenB SimenB merged commit 02faea6 into jestjs:master Feb 6, 2020
@SimenB
Copy link
Member

SimenB commented Feb 6, 2020

Thanks!

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline snapshots indented at col 0 when existing inline snapshots in file
5 participants