-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle null
being passed to createTransformer
#9955
Conversation
Hi @yinm! Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #9955 +/- ##
==========================================
- Coverage 64.08% 64.06% -0.02%
==========================================
Files 293 293
Lines 12457 12457
Branches 3069 3067 -2
==========================================
- Hits 7983 7981 -2
- Misses 3832 3833 +1
- Partials 642 643 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yinm, this is great! I've only got a nit for the changelog, code and test LGTM 👍
Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
Thank you for the review 🙏 |
null
being passed to createTransformer
Thanks @yinm! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
I took a regression bug in babel-jest.
The regression bug occurs since bb720d2#diff-ad0be0b5e1f4711c408a42bdbea512bcR43-R57 .
fixes #9926