Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix watch mode test with utimes #9967

Merged
merged 2 commits into from
May 4, 2020
Merged

chore: fix watch mode test with utimes #9967

merged 2 commits into from
May 4, 2020

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented May 4, 2020

Summary

It should be seconds, not ms.

(we cannot pass a Date object due to #2549)

Test plan

Green CI

@SimenB SimenB requested a review from thymikee May 4, 2020 11:12
SimenB
SimenB commented May 4, 2020
View reviewed changes
e2e/__tests__/watchModeNoAccess.test.ts
@@ -47,6 +44,8 @@ afterEach(async () => {
}
});

const getOneSecondAfterMs = (ms: number) => ms / 1000 + 1;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prettier won't allow me to do (ms / 1000) + 1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://twitter.com/markdalgleish/status/1252412005845069828

@codecov-io
Copy link

Codecov Report

Merging #9967 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9967   +/-   ##
=======================================
  Coverage   63.94%   63.94%           
=======================================
  Files         293      293           
  Lines       12488    12488           
  Branches     3081     3079    -2     
=======================================
  Hits         7985     7985           
  Misses       3859     3859           
  Partials      644      644

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d12d5...5fd4b8e. Read the comment docs.

@thymikee
Copy link
Collaborator

thymikee commented May 4, 2020

error Command failed with exit code 3221225477

Welp Windows

@SimenB
Copy link
Member Author

SimenB commented May 4, 2020 •
edited
Loading

Node 14 on windows seems subtly broken: nodejs/node#33166. I'll restart it though, seeing as this PR is specifically for Windows

@SimenB SimenB merged commit 03dbb2f into jestjs:master May 4, 2020
@SimenB SimenB deleted the fix-watch-mode-utimes-test branch May 4, 2020 12:15
This was referenced Nov 17, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 16, 2020
Open
Open
Open
Open
This was referenced Mar 28, 2021
Open
Open
This was referenced Mar 28, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 6, 2021
Open
Open
Open
Open
Open
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thymikee thymikee Awaiting requested review from thymikee

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SimenB @codecov-io @thymikee @facebook-github-bot