Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release barcode searches #558

Merged
merged 2 commits into from
Feb 12, 2021
Merged

Add release barcode searches #558

merged 2 commits into from
Feb 12, 2021

Conversation

ROpdebee
Copy link
Contributor

@ROpdebee ROpdebee commented Feb 11, 2021 •
edited

Re-adds %release-barcode% template token on release pages
Adds Spotify, Discogs, Amazon and IFPI ISRC search links with this barcode as examples.

@ROpdebee
mb_ALL-LINKS: Add release barcode searches
72dd571 
Adds %release-barcode% template token on release pages
Adds Spotify, Discogs, Amazon and IFPI ISRC search links with this barcode as examples.
@jesus2099
Copy link
Owner

Thanks very much @ROpdebee.
Could you bump version to 2021.2.12?

Also you should know that this script is no longer maintained on matter branch because I have been working on accepting a big PR for months (#244/#488).
The branch over there is not yet fully functional.

But I will of course merge your PR anyway. ☺️👍

@ROpdebee
Copy link
Contributor Author

Version bumped!

Do you have a checklist of things that need to be done on that branch? It seems like a massive improvement over the current version, so I'd be happy to help out where I can.

@jesus2099 jesus2099 merged commit d6a4162 into jesus2099:master Feb 12, 2021
@jesus2099 jesus2099 mentioned this pull request Feb 12, 2021
Closed
4 tasks
@jesus2099
Copy link
Owner

jesus2099 commented Feb 12, 2021 •
edited

Thank you very much! :)

There is a checklist at #488 but, for the moment, I prefer restoring stuff myself, there, to fully understand the big bang change, as it's already a PR in the beginning.

I will make a draft PR (it's something I just discovered), which will be easier to follow up than just a branch alone.
No it does not work out well.

@jesus2099 jesus2099 changed the title mb_ALL-LINKS: Add release barcode searches Add release barcode searches Feb 12, 2021
jesus2099 referenced this pull request Feb 12, 2021
@jesus2099
Removed RELEASE EVENT TOOLS from PLAIN TEXT TRACKLIST (it should be i…
c894e76 
…n ALL LINKS instead, #45)
jesus2099 pushed a commit that referenced this pull request Feb 20, 2021
@ROpdebee @jesus2099
mb_ALL-LINKS: Add release barcode searches (#558)
c82fac6 
Adds %release-barcode% template token on release pages
Adds Spotify, Discogs, Amazon and IFPI ISRC search links with this barcode as examples.
d6a4162
@jesus2099 jesus2099 mentioned this pull request Feb 20, 2021
Open
17 tasks
@ROpdebee ROpdebee deleted the patch-1 branch February 24, 2021 11:44
@jesus2099 jesus2099 added this to the 2021 milestone Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature mb_ALL-LINKS
Projects
None yet
Milestone
2021
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ROpdebee @jesus2099