Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update precommit #65

Merged
merged 9 commits into from
Feb 1, 2024
Merged

Update precommit #65

merged 9 commits into from
Feb 1, 2024

Conversation

rkansal47
Copy link
Member

@rkansal47 rkansal47 commented Nov 19, 2023 •
edited
Loading

Updating pre-commit requirements to follow the Scientific Python cookiecutter template.

Mostly results in a lot of cosmetic changes, but some significant ones are

  • No mutable default function arguments (potentially big bug!)
  • Switching to numpy.random.Generator functions instead of numpy.random.X (NPY002)
  • pathlib replacing os and open() for IO (PTH)

@rkansal47 rkansal47 merged commit cf5472b into jet-net:main Feb 1, 2024
1 check passed
@rkansal47 rkansal47 deleted the update-precommit branch February 1, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmduarte jmduarte Awaiting requested review from jmduarte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rkansal47 @lint-action