Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FsCodec.SystemTextJson re #14 #38

Merged
merged 19 commits into from
May 10, 2020
Merged

Add FsCodec.SystemTextJson re #14 #38

merged 19 commits into from
May 10, 2020

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented Mar 5, 2020

Extracted from work by @ylibrach in jet/equinox#197 jet/equinox#200 re #14

Intended as a drop-in replacement for FsCodec.NewtonsoftJson that can be used by 'simply' 'just' replacing the top level namespace and the assembly reference in your source code

@bartelink bartelink changed the title Add FsCode.SystemTextJson re #14 Add FsCodec.SystemTextJson re #14 Mar 5, 2020
@fluxlife
Copy link

Any chance there could be a beta release of this?

@bartelink
Copy link
Collaborator Author

bartelink commented Apr 28, 2020

@fluxlife Good question - this is pretty much ready to go, so we have choices

  1. literally release a beta from this branch like you said
  2. ping @NickDarvey re whether/when Port UnionConverter to STJ #43 will be fully ready (it's OK if that's a few days, more trying to get a rough idea), then we merge this and release 2.1.0
  3. merge this, release 2.1.0, let Port UnionConverter to STJ #43 release as a fast-follow 2.1.0
  4. @ylibrach when 2 or 3 happens, I'll apply it to feat!(CosmosStore): Azure.Cosmos 'V4' support / enable mocking Cosmos APIs equinox#197 and do another alpha out there too - would also appreciate a quick scan by you for any stuff we should fix in this PR/branch before baking this as the final 2.x era API for FsCodec.SystemTextJson

@bartelink
Copy link
Collaborator Author

bartelink commented May 2, 2020

Hopefully FsCodec.SystemTextJson (i.e. this PR) can have the JsonRecordConverter removed soon; it seems that dotnet/runtime#29812 has been prioritized in https://github.com/dotnet/runtime/projects/25#card-35157538

eta: Done in #49

@bartelink
Copy link
Collaborator Author

@fluxlife merging/releasing now

@bartelink bartelink merged commit 9b524de into master May 10, 2020
@bartelink bartelink deleted the stj branch October 7, 2020 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants