-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FsCodec.SystemTextJson re #14 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
changed the title
Add FsCode.SystemTextJson re #14
Add FsCodec.SystemTextJson re #14
Mar 5, 2020
bartelink
force-pushed
the
stj
branch
3 times, most recently
from
March 5, 2020 14:48
e2b375b
to
81bc30e
Compare
This was referenced Mar 5, 2020
This was referenced Mar 8, 2020
Any chance there could be a beta release of this? |
@fluxlife Good question - this is pretty much ready to go, so we have choices
|
Hopefully eta: Done in #49 |
@fluxlife merging/releasing now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from work by @ylibrach in jet/equinox#197 jet/equinox#200 re #14
Intended as a drop-in replacement for
FsCodec.NewtonsoftJson
that can be used by 'simply' 'just' replacing the top level namespace and the assembly reference in your source codeFsCodec.SystemTextJson
, together with a.Tests
assemblySettings
toOptions
to match STJ naming conventionsJsonOptionConverter
as a shim (as of STJ 4.7, F# options are still not supported out of the box 😿User Story: Developers using JsonSerializer want it to handle common F# types well dotnet/runtime#29812)AddsJsonRecordConverter
as a shim (as of STJ 4.7, F# records are still not supported out of the box 😿User Story: Developers using JsonSerializer want it to handle common F# types well dotnet/runtime#29812)JsonRecordConverter
removed prior to merge, see Require STJ v5; Remove JsonRecordConverter #49 👇Make OptionConverter symmetric by makingDocument handling ofSome null
render as perNone
Some null
as not being special-cased Remove Some null handling wart #39FsCodec.Box.Codec
toFsCodec.Box
package Extract FsCodec.Box.Codec to its own package #46.ToByteArrayCodec()
andToJsonElementCodec()
overloads on SystemTextJson and NewtonsoftJson converters respectively to enable Stores to be able to pick one or the other5.0.0-preview.3
dependency so we don't need aJsonRecordConverter
anymore[ ] Port UnionConverter Port UnionConverter to STJ #43deferred, noted in README.md - Port UnionConverter to STJ #43 is pretty complete but needs rebasing and final tweaks; The intent is @NickDarvey will complete this work - there's no eta at present due to competing demands on his time