Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulate linger/batching semantics #68

Merged
merged 4 commits into from
Jul 22, 2020
Merged

Encapsulate linger/batching semantics #68

merged 4 commits into from
Jul 22, 2020

Conversation

bartelink
Copy link
Collaborator

@bartelink bartelink commented Jul 22, 2020 •
edited
Loading

Prompted by Confluent.Kafka changing the default linger from 0.5 ms to 5 ms in v 1.5.0 (see #65), this revises the configuration API to force specification of a linger value in all cases.

  • There is one sensitive API which Propulsion.Kafka uses: KafkaProducerConfig.Create, which I've Obsoleted
  • The other change (CreateWithConfigOverrides -> Create and associated removal of arguments) is safe as it is only in consumer code

resolves #65

@bartelink bartelink force-pushed the mandatory-linger branch 2 times, most recently from aff9fd5 to f8778f0 Compare July 22, 2020 14:03
wantastic84
wantastic84 approved these changes Jul 22, 2020
View reviewed changes
Copy link
Collaborator

@wantastic84 wantastic84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bartelink bartelink merged commit 64b9eb5 into master Jul 22, 2020
@bartelink bartelink deleted the mandatory-linger branch July 22, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swrhim swrhim swrhim approved these changes

@wantastic84 wantastic84 wantastic84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check linger settings for upgrading to CK 1.5 dependency
3 participants
@bartelink @swrhim @wantastic84