-
Notifications
You must be signed in to change notification settings - Fork 18
[WIP] Task Driver Plugin Support for Nomad 0.9.x+ #17
base: master
Are you sure you want to change the base?
Conversation
- Keep track of all the performance counters so they can be queried later by other packages such as the Nomad Task Driver plugin
- Wait semantics are more managable - Containers are started by RunContained returning a running container - Can send shutdown signal to container explicitly via function call with timeout/delay before hard kill - Can wait for a container to be done and return results
3227216
to
596ac5e
Compare
@justenwalker you may find the second known issue related to this: hashicorp/go-plugin#125 We ran into it when developing our own Task Driver plugin in C# for IIS. |
Thanks for the tip! Looks like this change is at hashicorp/go-plugin@8091134 Unfortunately, this means it isn't in the 0.9.x line; and it also didn't make it into v0.10.0-rc1 either. However, it is in master now; so perhaps it will be in the GA version of v0.10.0 when the release gets cut. Unfortunately, this means that the plugin will likely not work correctly on 0.9.x unless this update gets back-ported and they release 0.9.7. Still, this is a good place to start debugging, to see if the issue still persists on Nomad HEAD. |
Yeah, I should have mentioned that it was slated for Nomad 0.10.1. We were only able to reproduce the issue when Nomad is not stopped cleanly. Not sure if you're experiencing different. For us, the infrequency of that happening in our environment makes the risk worth the reward. But this is a different scenario, so I understand being more cautious. :) |
In my experience, it is unable to start the plugin regardless of how clean the plugin is shut down; and it persists across subsequent restarts until the local client state is wiped; so that's a pretty serious issue. |
Add support for TaskDriver plugin
Change Log:
Known Issues: