Add logging to Handlers #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(not merged yet because #2) |
|
needs some TODO comments in the emitted code to make people consider replacing with higher level logging |
|
@fnipo I'm strongly considering not doing this as jet/propulsion#60 means you now a) always supply a |
|
Abandoning in favor of #65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propulsion does not do logging of exceptions for failed handling calls (it counts them and gathers latencies only).
While it's technically correct to hence expect folk to Just Do Some Logging, this has proved a common stumbling block, so adding this boilerplate as a a starter.
This adds lightweight placeholder logging to the templates, though its recommended that it be replaced with relevant domain-specific logging instead