Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename DeprecatedRawName ? #147

Closed
bartelink opened this issue Aug 13, 2019 · 3 comments
Closed

rename DeprecatedRawName ? #147

bartelink opened this issue Aug 13, 2019 · 3 comments
Milestone

Comments

@bartelink
Copy link
Collaborator

The name DeprecatedRawName was chosen in haste; I was seeking to:
a) give a pejorative name to make people think before putting string concats composing a name into their app logic - AggregateId provides a clean way to compose a category name literal with an identifier in code
b) give a strong nudge to use AggregateId as it ensures that the out-of-the-box default separator used by EventStore ("-") gets used which makes $ec- streams etc work
c) provides scope to map AggregateId to something appropriate for any new store

On reflection, while there's nothing wrong with the above opinionated stance, the reality is that plenty existing codebases already compose names in a variety of ways, and will pick a backend and stick with it.

So, for the final v2 release, I'm open to a name change if we can settle on one. Open to any thoughts...

@bartelink
Copy link
Collaborator Author

Ccing @ameier38 in case you can think of a better name than StreamName

@ameier38
Copy link

I like StreamName 👍

@bartelink
Copy link
Collaborator Author

Completed in #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants