DynamoStore: Cache decoding of Data/Meta #331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic to correctly handle cases where the reader traverses the
TimelineEvent.Data
more than once.In the typical case, Equinox-controlled loads will only walk the events exactly once [until
isOrigin
stops the search]However in more exotic cases such as in projection loops, there can be cases (and this issue surfaced as an exception in such logic) where layering is such that filtering layers perform some pre-traversals.
It has been argued by @yreynhout that compression doesn't belong in this layer; certainly its absence would have avoided this specific issue, and I can't say I like the impl having ugly excuses and guards as this PR introduces.
Removing it would at a minimum entail adding some form of content-encoding/content-type to the
ITimelineData
in order for an outer layer to be able to drive it. Am considering doing it, likely with a breaking format change prior to entering the-rc
phase.