internal/devpkg: move flake code into new nix/flake package #1789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move `devpkg.FlakeRef` and `devpkg.FlakeInstallable` into a standalone `go.jetpack.io/devbox/nix/flake` package. This allows two things: - The backend can import and use these types because they're no longer internal. - The search client can use them without creating an import cycle.
savil
approved these changes
Feb 5, 2024
cklim2024
reviewed
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
devpkg.FlakeRefanddevpkg.FlakeInstallableinto a standalonego.jetpack.io/devbox/nix/flakepackage. This allows two things:Note that the types were renamed, which messed up git's ability to detect this is a file move. The summary of changes is:
FlakeRef→flake.RefParseFlakeRef→flake.ParseRefFlakeInstallable→flake.InstallableParseFlakeInstallable→flake.ParseInstallableFlakeTypeIndirect,FlakeTypePath, ... →flake.TypeIndirect,flake.TypePath, ...