internal/searcher,lock: use /v2/resolve endpoint #1790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `DEVBOX_FEATURE_RESOLVE_V2` feature flag that enables the new `/v2/resolve` endpoint when resolving packages. The new endpoint unlocks a couple of improvements: - We no longer need to call `nix store path-from-hash-part` (which incurs a network request) for every `fetchClosure` package. The full store path is returned directly by the API. - The resolved package response includes store paths for all known outputs, allowing us to support `fetchClosure` for non-default outputs as well. - The new endpoint returns a flake installable rather than a nixpkgs commit hash and attribute path. This gives more flexibility, allowing the API to potentially return packages from sources other than nixpkgs.
mikeland73
approved these changes
Feb 7, 2024
Comment on lines
+44
to
+46
|
|
||
| // ResolveResponse is a response from the /v2/resolve endpoint. | ||
| type ResolveResponse struct { |
There was a problem hiding this comment.
Would be nice to share these with search service if possible.
Agreed. I can do that once the backend change is deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
DEVBOX_FEATURE_RESOLVE_V2feature flag that enables the new/v2/resolveendpoint when resolving packages. The new endpoint unlocks a couple of improvements:nix store path-from-hash-part(which incurs a network request) for everyfetchClosurepackage. The full store path is returned directly by the API.fetchClosurefor non-default outputs as well.