Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/stacks/drupal: fix for local #1801

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

gcurtis
Copy link
Collaborator

@gcurtis gcurtis commented Feb 9, 2024

Fix the drupal example so that it runs locally. It's still broken in CI due to some filesystem permissions issues that I don't have time to debug. The example had a few errors, some probably due to the example drifting too far from the most recent Devbox version.

  • Add curl to devbox.json so that run_test works.
  • Increase the sleep duration (2 seconds wasn't long enough on my M1).
  • Symlink devbox.d/web -> ../web so that nginx serves the drupal site instead of a static index.html.
  • Update the curl command to hit localhost:8081, which is what nginx is listening on.
  • Set MYSQL_UNIX_PORT via the env field in devbox.json. I think otherwise the plugin overrides it back to its default value.
  • Update some composer dependencies to address dependabot security issues.

@Lagoja
Copy link
Contributor

Lagoja commented Feb 9, 2024

Drupal Test is still failing in CI with the following:

2024-02-09T19:56:14.2244712Z         chown: changing ownership of '$WORK/.devbox/virtenv/mariadb/data': Operation not permitted
2024-02-09T19:56:14.2246280Z         Error: error running script "run_test" in Devbox: exit status 1
2024-02-09T19:56:14.2247035Z         
2024-02-09T19:56:14.2247445Z         [exit status 1]
2024-02-09T19:56:14.2248691Z         FAIL: /tmp/TestExamples3040603473/026/stacks_drupal_run_test.test.txt:2: unexpected command failure

Fix the drupal example so that it runs locally. It's still broken in CI
due to some filesystem permissions issues that I don't have time to
debug. The example had a few errors, some probably due to the example
drifting too far from the most recent Devbox version.

- Add `curl` to `devbox.json` so that `run_test` works.
- Increase the sleep duration (2 seconds wasn't long enough on my M1).
- Symlink devbox.d/web -> ../web so that nginx serves the drupal site
  instead of a static index.html.
- Update the curl command to hit localhost:8081, which is what nginx is
  listening on.
- Set `MYSQL_UNIX_PORT` via the `env` field in `devbox.json`. I think
  otherwise the plugin overrides it back to its default value.
- Update some composer dependencies to address dependabot security
  issues.
@gcurtis
Copy link
Collaborator Author

gcurtis commented Feb 9, 2024

I put back the skip for the test in CI. It runs locally, but I don't have time to figure out the filesystem permissions issues that are going on in CI.

@gcurtis gcurtis changed the title examples/stacks/drupal: fix and unskip from tests examples/stacks/drupal: fix for local Feb 9, 2024
@gcurtis gcurtis merged commit 95d5c2b into main Feb 9, 2024
24 checks passed
@gcurtis gcurtis deleted the gcurtis/drupal-example branch February 9, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants